test: migrate math/base/special/cphasef to ULP-based assertions - #14362
Merged
Conversation
Replaces relative tolerance comparisons in the `cphasef` fixture loops with ULP difference assertions via `@stdlib/number/float32/base/assert/is-almost-same-value`, using the minimum ULP bound which passes over the full fixture set. Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Good First PR
Contributor
Coverage ReportNo coverage information available. |
kgryte
marked this pull request as ready for review
August 17, 2026 22:29
stdlib-bot
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/cphaseffrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputations in the fixture loops oftest/test.jsandtest/test.native.jswitht.strictEqual( isAlmostSameValue( actual, expected[ i ], N ), true, 'returns expected value' );.@stdlib/number/float32/base/assert/is-almost-same-valuerequire (the single-precision variant, matching the idiom already used for other*fpackages, e.g.math/base/special/atan2fandmath/base/special/rad2degf) and removes the now-unused@stdlib/math/base/special/absfand@stdlib/constants/float32/epsrequires.Only the two test files are modified; no fixtures, implementations, or other packages are touched.
ULP bounds
The following bounds are the measured minimum for each fixture set. Each was found by computing the exact ULP distance between the returned and expected value for every fixture point, and then confirmed by re-running the suite at
N - 1(which fails):N - 1resultpositive_positive.json2N = 1negative_positive.json1N = 0negative_negative.json1N = 0The same three bounds hold for both the JavaScript and the native (C) implementation, so
test.jsandtest.native.jsuse identical values. The two implementations do return differing values for a small number of fixture points (27 / 2 / 2 respectively), but in every such case both results remain within the bounds above, so no separate C-specific tolerances are required.The previous relative tolerances were
1.3 * EPSforpositive_positiveandEPSfor the other two fixture sets, which is consistent with the2 / 1 / 1ULP bounds above.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed:
make test TESTS_FILTER=".*/math/base/special/cphasef/.*"passes: 7052 assertions intest/test.jsand 7052 intest/test.native.js, 0 failing. The native add-on was built locally, sotest.native.jswas actually executed rather than skipped.etc/eslint/.eslintrc.tests.js.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. The agent studied the already-merged conversions for
math/base/special/cphase,math/base/special/atan2f, andmath/base/special/rad2degfin order to mirror the established idiom, applied the equivalent edits here, measured the minimum ULP bounds empirically over the full fixture set, and verified the result by building the native add-on and running both test files undermake test.@stdlib-js/reviewers
Generated by Claude Code